avm2: Add support for focus-related events #16581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
commented
Jun 3, 2024
kjarosh
changed the title
danielhjacobs
added
A-avm2
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
from
563d874
to
95344fe
Compare
This was referenced Jul 12, 2024
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
4 times, most recently
from
e22f177
to
8efdf83
Compare
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
3 times, most recently
from
3631050
to
7351646
Compare
kjarosh
changed the title
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
2 times, most recently
from
68d101d
to
a804f5f
Compare
kjarosh
added
waiting-on-review
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
2 times, most recently
from
51de953
to
cb2a3a8
Compare
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
from
cb2a3a8
to
e8eb9b4
Compare
Lord-McSweeney
approved these changes
Jul 25, 2024
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
from
e8eb9b4
to
5a3bb1f
Compare
This method allows constructing FocusEvents.
When clicking a focusable by mouse object in AVM2, the focus should be updated.
The order of events seen during testing suggests that the focus is updated before dispatching any mouse-related events.
This test checks which objects are focusable by mouse in AVM1.
This test verifies the behavior of focus-related events when the window focus is lost.
This test verifies the behavior of focus-related events when changing focus programmatically.
This test verifies the behavior of focus-related events when changing focus using keyboard.
This test verifies the behavior of focus-related events when changing focus to the same object using keyboard.
This test verifies the behavior of focus-related events when using keyboard navigation.
This test verifies the behavior of focus-related events when changing focus using mouse.
This test verifies the behavior of focus-related events when changing focus to the same object using mouse.
This test verifies the behavior of focus-related events when changing focus using keyboard and mouse interchangeably.
This test verifies the behavior of focus-related events when trying to focus various interactive objects using mouse.
kjarosh
force-pushed
the
tab-ordering-avm2-events
branch
from
5a3bb1f
to
256fb85
Compare
|
Given two approvals, and all review notes fixed, I guess this is good to go now...? |
|
awesome work! thanks! |
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5443, progresses #17084, fixes (probably) #17064, progresses (probably) #14993.
This PR adds support for focusing objects on mouse click, and for dispatching focus-related events:
focusOut,mouseFocusChange, andkeyFocusChange.Behavior of those events and focusing objects by mouse is covered by tests:
avm2/focus_events_mouse_basic,avm2/focus_events_key_same_object,avm2/focus_events_key_basic,avm2/focus_events_code,avm2/focusrect_focuslost,avm1/focus_mouse_focusable.