chore: Move lint configuration from .cargo/config.toml to Cargo.toml
#14614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
force-pushed
the
cleanup-lint-config
branch
from
4ea8d7b
to
902f817
Compare
|
The second commit was needed because unfortunately this does not apply to all workspace members automatically... Related: rust-lang/rust-clippy#11933 |
torokati44
force-pushed
the
cleanup-lint-config
branch
from
b207731
to
856b097
Compare
Aaron1011
approved these changes
Jan 4, 2024
torokati44
force-pushed
the
cleanup-lint-config
branch
from
856b097
to
1923ab1
Compare
This got stabilized in Rust 1.74.
torokati44
force-pushed
the
cleanup-lint-config
branch
from
1923ab1
to
82b8000
Compare
|
This got a little bit less elegant since approval (the second commit is not all one-liners now). |
Aaron1011
approved these changes
Jan 5, 2024
|
Thank you for the double approval! |
sleepycatcoding
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got stabilized in Rust 1.74:
https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#lints
https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-lints-section
https://doc.rust-lang.org/nightly/cargo/reference/workspaces.html#the-lints-table
rust-lang/cargo#5034 is done by rust-lang/cargo#12115, and rust-lang/cargo#12148 is also merged.