chore: Remove static_assertions dependency
#10348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we keep the concrete values for the 2 platforms? |
Why? I thought it would be nicer to compute the sizes using current pointer size. |
|
The formula happens to check out now, but it doesn't represent a consistent underlying rule. As in:
So possible refactoring of the structs could throw the formula out of whack (plus it's reliant on what alignment our current platforms happen to have right now). And aside from being a "regression test", having specific values at hand makes it slightly easier to eyeball memory traffic, at least for me. |
|
I agree, I prefer the explicit values in this case. |
relrelb
force-pushed
the
static_assertions
branch
2 times, most recently
from
86e0b56 to
eba0366
Compare
|
Done. |
adrian17
approved these changes
Mar 25, 2023
`static_assertions` seems unmaintained, and anyway `assert!()` is usable in `const` contexts since Rust 1.57.0: https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html#panic-in-const-contexts So simply use the suggested method instead. Also the `rustversion` dependency is no longer needed because rust-lang/rust#94075 already landed in stable.
relrelb
force-pushed
the
static_assertions
branch
from
eba0366 to
384af89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static_assertionsseems unmaintained, and anywayassert!()is usable inconstcontexts since Rust 1.57.0:https://blog.rust-lang.org/2021/12/02/Rust-1.57.0.html#panic-in-const-contexts So simply use the suggested method instead.
Also the
rustversiondependency is no longer needed because rust-lang/rust#94075 already landed in stable.