chore: all warehouses support views in ListTables #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
force-pushed
the
fix.listcolumns
branch
2 times, most recently
from
f87f899 to
d90bbbc
Compare
atzoum
force-pushed
the
fix.listcolumns
branch
from
d90bbbc to
3fa0e0f
Compare
shubhammehra4
approved these changes
Aug 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 85.58% 85.58% -0.01%
==========================================
Files 78 78
Lines 3330 3343 +13
==========================================
+ Hits 2850 2861 +11
- Misses 327 328 +1
- Partials 153 154 +1 ☔ View full report in Codecov by Sentry. |
Merged
atzoum
pushed a commit
that referenced
this pull request
Sep 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.10.0](v1.9.0...v1.10.0) (2024-09-12) ### Features * **databricks:** bump github.com/databricks/databricks-sql-go from 1.6.0 to 1.6.1 ([#174](#174)) ([8cab1fd](8cab1fd)) * **snowflake:** bump github.com/snowflakedb/gosnowflake from 1.10.1 to 1.11.1 ([#171](#171)) ([e64ba77](e64ba77)) * support dialect-aware query conditions ([#180](#180)) ([08906ee](08906ee)) ### Miscellaneous * all warehouses support views in ListTables ([#169](#169)) ([098a378](098a378)) * **deps:** bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.27 to 1.17.32 ([#179](#179)) ([47afb2e](47afb2e)) * **deps:** bump github.com/rudderlabs/rudder-go-kit from 0.36.2 to 0.40.0 ([#178](#178)) ([a4ee52e](a4ee52e)) * **deps:** bump google.golang.org/api from 0.194.0 to 0.196.0 ([#177](#177)) ([aaee20d](aaee20d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IncludesViewsInListTablesflag from integration testsListColumnsas wellSecurity