Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error logging #4288

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jan 5, 2024

Description

  • Currently, we are logging as a byte sequence. GA link.
  Failed Records from both services should be the same%!(EXTRA []uint8=[123 34 105 100 34 58 34 34 44 34 116 97 115 107 115 34 58 110 117 108 108 125], []uint8=[123 34 105 100 34 58 34 34 44 34 116 97 115 107 115 34 58 110 117 108 108 125], []uint8=[123 34 105 100 34 58 34 56 101 51 53 98 55 56 53 98 55 48 56 52 56 49 99 56 100 100 53 97 101 50 101 99 53 52 98 54 101 53 99 34 44 34 116 97 115 107 115 34 58 91 123 34 105 100 34 58 34 116 97 115 107 95 114 117 110 95 105 100 34 44 34 115 111 117 114 99 101 115 34 58 91 123 34 105 100 34 58 34 115 111 117 114 99 101 95 105 100 34 44 34 114 101 99 111 114 100 115 34 58 110 117 108 108 44 34 100 101 115 116 105 110 97 116 105 111 110 115 34 58 91 123 34 105 100 34 58 34 100 101 115 116 105 110 97 116 105 111 110 95 105 100 34 44 34 114 101 99 111 114 100 115 34 58 91 123 34 105 100 34 58 34 49 34 125 44 123 34 105 100 34 58 34 50 34 125 44 123 34 105 100 34 58 34 50 34 125 44 123 34 105 100 34 58 34 51 34 125 93 125 93 125 93 125 93 125], <nil>)
  • Log as string instead of byte sequence for better debuggability.

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link
Contributor

coderabbitai bot commented Jan 5, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1c3fb01) 73.88% compared to head (17e4a59) 73.96%.
Report is 5 commits behind head on master.

Files Patch % Lines
app/apphandlers/setup.go 33.33% 5 Missing and 1 partial ⚠️
app/apphandlers/processorAppHandler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4288      +/-   ##
==========================================
+ Coverage   73.88%   73.96%   +0.08%     
==========================================
  Files         388      388              
  Lines       55098    55127      +29     
==========================================
+ Hits        40709    40777      +68     
+ Misses      12060    12023      -37     
+ Partials     2329     2327       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit 9cb9caf into master Jan 8, 2024
45 checks passed
@achettyiitr achettyiitr deleted the chore.improve-error-logging branch January 8, 2024 04:42
This was referenced Jan 15, 2024
This was referenced Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants