-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return only the latest namespace entry when fetching tables from warehouse #4287
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4287 +/- ##
==========================================
- Coverage 73.95% 73.92% -0.04%
==========================================
Files 389 389
Lines 55209 55206 -3
==========================================
- Hits 40831 40811 -20
- Misses 12054 12068 +14
- Partials 2324 2327 +3 ☔ View full report in Codecov by Sentry. |
8fd15ff
to
92ddfe3
Compare
…/rudderlabs/rudder-server into fix.pro-1605.returnLatestNamespace
9cb6bd4
to
a3789d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I left a comment about the test.
…/rudderlabs/rudder-server into fix.pro-1605.returnLatestNamespace
Description
Modify the query in the
GetTablesForConnection
method to group by source_id and destination_id. This will allow us to get only the latest namespace per source_id and destination_id pair.Tested
Linear Ticket
ticket
Security