Closed
Conversation
Currently, there seem to be compilation issues when attempting to compile with lib8 v7. This patch ensures we only attempt to build the gem against a compatible v6 version of libv8.
Collaborator
|
@ignisf do we have a topic to track issues with libv8 7 ? are there any know incompatibilities ? |
Contributor
|
There's an issue (rubyjs/libv8#274), however I've not released a stable version of libv8 7 that warrants fixing mini_racer to v8<7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there seem to be compilation issues when attempting to compile with
lib8 v7. This patch ensures we only attempt to build the gem against a
compatible v6 version of libv8.