Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Clicking on a line in the Debug Console doesn't switch focus to the file in question #180

Closed
perlun opened this issue Jul 14, 2017 · 6 comments
Labels
feature-request Adds currently unsupported functionality upstream Root cause is upstream of project

Comments

@perlun
Copy link

perlun commented Jul 14, 2017

First, let me say a huge thanks for a great extension! I've been using it for a while for just editing Ruby projects, but hadn't tried the debug experience with it. It's the best I've ever seen with Ruby, great work from you all!!!


Your environment

  • vscode-ruby version: 0.12.1
  • Ruby version: 2.4.1
  • VS Code version: 1.14.0
  • Operating System: macOS
  • Hardware (optional):

Make sure you have ruby, ruby-debug-ide and ruby-debug-basex19 installed before submitting your issue -- thank you !

Expected behavior

Clicking on a link from e.g. rspec output should switch keyboard focus to the file in question.

Actual behavior

Focus is moved to the editing field in the Debug Console, where you can enter Ruby code.

Steps to reproduce the problem

  1. Run the rspec - active file spec only task.
  2. Click on a link to a line number in a file.
  3. Focus is on the > line below
  4. If i Cmd-click on a line, a new tab opens in vscode with the correct behavior, but if I just click without cmd it does not. Is the bug in vscode-ruby or in vscode?
  5. Also, if the file is not already open, it also works correctly! So only if the file was already active and visible the bug occurs, it seems.

image

@rebornix
Copy link
Member

Moving the result to integrated terminal might solve this problem

@rebornix rebornix added the feature-request Adds currently unsupported functionality label Jul 25, 2017
@rebornix rebornix added this to the 1.0 milestone Jul 25, 2017
@rebornix
Copy link
Member

Re microsoft/vscode#27713

@rebornix rebornix added the upstream Root cause is upstream of project label Aug 11, 2017
@perlun
Copy link
Author

perlun commented Aug 17, 2017

Moving the result to integrated terminal might solve this problem

How do you do that? I tried setting the console setting which didn't work for me. See microsoft/vscode#32696

@perlun
Copy link
Author

perlun commented Oct 31, 2017

Ping @rebornix - it would be great to be able to move the result to integrated terminal. Would you have time to look into it? (or: would you accept a PR that fixes it?)

@perlun
Copy link
Author

perlun commented Mar 9, 2018

@rebornix and @wingrunr21 With 0.17.0, these references are no longer underlined, and you cannot click them. This is sad, it's a nice feature that used to work in some earlier version. (0.14? 0.15?)

@wingrunr21 wingrunr21 removed this from the 1.0 milestone Apr 3, 2018
@wingrunr21
Copy link
Collaborator

Closing for issue cleanup. Apologies if this is still an issue. We are working to improve the core extension experience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Adds currently unsupported functionality upstream Root cause is upstream of project
Projects
None yet
Development

No branches or pull requests

3 participants