Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug console: does not properly handle extended color sequences #32696

Closed
perlun opened this issue Aug 17, 2017 · 3 comments
Closed

Debug console: does not properly handle extended color sequences #32696

perlun opened this issue Aug 17, 2017 · 3 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@perlun
Copy link

perlun commented Aug 17, 2017

  • VSCode Version: Version 1.15.0 (1.15.0)
  • OS Version: Darwin ecvaawplun5.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jun 15 17:36:27 PDT 2017; root:xnu-3789.70.16~2/RELEASE_X86_64 x86_64

Steps to Reproduce:

  1. Run a task which executes a command that generates extended color sequences (such as the rainbow Ruby gem).
  2. As can be seen, certain escape sequences (probably traditional ANSI codes) work, whereas the extended ones are failing. More info about extended color codes can be found here, where the 38,5 prefix is explained more.

image

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Aug 17, 2017
@weinand weinand added this to the Backlog milestone Aug 17, 2017
@weinand weinand removed their assignment Aug 17, 2017
@weinand
Copy link
Contributor

weinand commented Aug 17, 2017

The debug console doesn't support extended color sequences because it was never meant to be a real terminal (e.g. it does not even support input!).
We have no plans to change this.

Please configure your launch config to use an "integratedTerminal" or "externalTerminal". They might support extended colors.

@perlun
Copy link
Author

perlun commented Aug 17, 2017

Thanks @weinand

Please configure your launch config to use an "integratedTerminal" or "externalTerminal". They might support extended colors.

I will give this a try. I tried to change this by setting this:

      "console": "integratedTerminal"

...however, it didn't seem to make any difference. I guess this is a problem with the extension being used, not supporting integratedTerminal etc.

I will discuss with the extension author(s). Thanks anyway! 😄

@perlun perlun closed this as completed Aug 17, 2017
@weinand
Copy link
Contributor

weinand commented Aug 17, 2017

@perlun yes, the debug extension have to opt into the terminal feature but after they have done this, they get the functionality basically for free (because it is implemented on the VS Code side).
Here is the link to the terminal feature that we've added a year ago: https://code.visualstudio.com/updates/v1_5#_additions-to-the-debug-protocol

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants