Aws sdk

[arthurnn]

• Replace s3 gem with aws-sdk-core (amazon's gem)
• add a restore method, so we can delete files and restore them. (I tested that in staging, and it worked)

review @dwradcliffe @sferik @qrush

[simi]

So restore method is meant to be used manually only?

[sferik]

👍 overall. This dependency ties us tighter to multi_json. I’m okay with it but it will make your project to completely eliminate the multi_json dependency more difficult.

[arthurnn]

Right. I guess multi_json will stick around for a while still.

[sferik]

💥 jmespath/jmespath.rb#7

[arthurnn]

thats awesome @sferik

[arthurnn]

So restore method is meant to be used manually only?

That method , is mainly for #923 , so we can delete gems and restore them (manually) if need it.

[dwradcliffe]

So we're expecting the get to fail every time and raise the exception?

[simi]

@arthurnn sure. But I was thinking about whole workflow.

Once deletion is created, those two hooks are triggered:

# app/models/deletion.rb
...
  after_create :remove_from_index #removed from index
  after_commit :remove_from_storage #removed from storage
...

But according to note from #923

Since we're using a versioned S3 bucket, we are in theory prepared for a "why_ scenario" where someone removes all of their gems that others depend on, since we can just restore them out of the bucket if something/someone went truly wrong.

it will be good to be prepared to rollback deletion also.

With restore method you'll only add it back to the storage, but not to the index. Is that alright?

So the flow will be like:

1. open server rails console
2. run RubygemFs.instance.restore(key)
3. still keep it "unindexed"

❓

[simi]

Only restore (meant to be callable manually),store, remove, get and base_dir methods are used in #923 and master for RubygemFs.instances.

What about to add blank restore method (or raise NotImplementedError) to RubygemFs::Local and keep another methods (like bucket or s3 in RubygemFs::S3) private ?

[arthurnn]

With restore method you'll only add it back to the storage, but not to the index. Is that alright?

Yes

So the flow will be like:

No, After this gets merged I will add a restore method to #923 Deletion model so we can restore the s3 file and the index flag on the db.

Regarding the API on RubygemFs, yes, I should make some common methods public and the others private. I will do that.

[simi]

Thanks @arthurnn, that makes sense now.

[arthurnn]

@dwradcliffe

So we're expecting the get to fail every time and raise the exception?

Yes, thats how the API works. it returns a 404 with a versionId, and on the sdk gem a 404 means an exception.

[dwradcliffe]

@arthurnn ok cool, just making sure I understood.

[dwradcliffe]

👍 🚢