Local development fixes#494
Merged
Merged
Conversation
This fixes path problems when setting up a local development environment. In dev, Fog uses the local storage provider and Indexer assumes all operations will result in files being written to `Pusher.server_path + "/gems"`. With Fog in the mix, this actually becomes `Pusher.server_path + s3_bucket + "/gems"`. (`Pusher.server_path` defaults to the `server` directory.) Removing the s3_bucket name from `rubygems.yml` and the `'gems'` from `Indexer#fog` means that gems and index updates are served out of the `Pusher.server_path` as expected. No tests for this as the behavior only occurs in the development environment.
`Pusher#upload` was extracted out into `Indexer` in a802782. This updates the index rake task to use `Indexer.new.perform` instead of the individual upload steps. Stats get lost but the upshot is the task works again. Hooray!
Contributor
Author
|
I've just updated the wiki to reflect issues and notes that I kept while working on some bundler-api issues yesterday. https://github.com/rubygems/rubygems.org/wiki/Development-Setup |
Contributor
|
Thanks, great commit messages, and a 👍 on updating the wiki. |
Contributor
Author
|
Thanks for the kind words @adkron. Glad I could help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to assist with a local development environment.
write_gem,upload, and friends work the way we expectgemcutter:update:indexto useIndexer