Add a script to restore a yanked version #1549
Conversation
Restoring a version will remove the yanked version line from our versions response. compact index clients will end up requesting entire versions response. It would be best to regenerate `versions.list` file. `RubygemFs::Local` does not implement `restore` method as there is no way to restore a deleted file locally. This script won't work in development env.
| def restore! | ||
| restore_to_index | ||
| restore_to_storage | ||
| destroy! |
There was a problem hiding this comment.
Should we mark as restored, instead of deleting the entry?
There was a problem hiding this comment.
Given that we want this restored version to be yankable in future, adding a restored flag would introduce two paths for deletion/yanking of a version. One where we create a new deletion record and other where we check if deletion record already exists and mark restored = false. I think it would create unnecessary confusion.
Can you please explain what is the value of marking it restored instead of deleting the record?
There was a problem hiding this comment.
Can you please explain what is the value of marking it restored instead of deleting the record?
The value, would be to have a breadcrumb if deleted/restored gems, for future data finds.
However, I don't know how much do we care about that or not.
I agree that adding that flag would add more complexity to the code.
|
Thanks for automating this! |
closes: #1548
RubygemFs::Localdoes not implementrestoremethod as there isno way to restore a deleted file locally. This script won't work in
development env.