Skip to content

Added html formatted emails#1535

Closed
sagarkaurav wants to merge 2 commits into
rubygems:masterfrom
sagarkaurav:html-formatted-mails
Closed

Added html formatted emails#1535
sagarkaurav wants to merge 2 commits into
rubygems:masterfrom
sagarkaurav:html-formatted-mails

Conversation

@sagarkaurav
Copy link
Copy Markdown

corrected error in mailer.html.erb layout

removed the css link from mailer.html.erb layout

Squashed last three commits. added html formatted mail
mail1

corrected error in mailer.html.erb layout

removed the css link from mailer.html.erb layout

Squashed last three commits. added html formatted mail
@sagarkaurav
Copy link
Copy Markdown
Author

@sonalkr132

@sonalkr132
Copy link
Copy Markdown
Member

Hi @sagarkaurav,

IMHO, your proposed design in not up to par. You should checkout these templates: https://github.com/sendwithus/templates/tree/master/templates. Please read the license on their canonical github repo before you decide to use any of them.

@homu
Copy link
Copy Markdown
Contributor

homu commented Jan 8, 2017

☔ The latest upstream changes (presumably #1522) made this pull request unmergeable. Please resolve the merge conflicts.

@dwradcliffe
Copy link
Copy Markdown
Member

Closing this since it is stale. Feel free to open a new PR when you've fixed it up. 😄

@dwradcliffe dwradcliffe closed this May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants