Validate email confirmation on sign up and profile update

[sonalkr132]

Closes: #1512

Users will be required to retype their email in email confirmation field.
Sign up page - Profile update page

[GBH]

Personally, I don't like this solution for these reasons:

Signup

• During signup it's clunky to ask for email twice
• If email is entered incorrectly it's not a big deal as user can try again. Side effect is that you end up with dead account. But that can be cleaned up easily by purging old unconfirmed accounts.

Profile update

• Clunky again. If I want to change only my twitter handle it will force me to fill email address confirmation.
• Nothing stops me from copy/pasting miss-typed email. That makes sense more for passwords (can't copy paste that)
• If I end up copy/pasting bad email address I again successfully locked myself out from the account.

So with this it's still possible to lock yourself out. With #1518 it would be impossible to do that because you still can login back and fix error.

[sonalkr132]

Thank your for your feedback @GBH
I would suggest minor correction 😄

email is entered incorrectly it's not a big deal as user can try again

Username would no longer be available.

If I want to change only my twitter handle it will force me to fill email address confirmation.

You would only need to fill in email confirmation if you change your original email.

EDIT: Added caveat for sign up.

[sonalkr132]

See #1531