consolidate code that generates links#1487
Merged
Merged
Conversation
sonalkr132
approved these changes
Nov 10, 2016
dwradcliffe
approved these changes
Nov 12, 2016
Contributor
Author
|
thanks all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In wanting to push #1234 (or #724) forward, I extracted the common logic around generating links.
The other PRs generate the documentation link much the same way as the wiki link.
So this makes them generated with a common function.
The larger goal being to just have
show.html.erbgenerate the list of links in a single loop."rubygems.show.links.#{name}"and.links.#{name}- this PR converges them. (I can converge on the full version if you prefer):idto all links, in order to simplify generation.Thanks