Skip to content

Add recent uploads page#1418

Closed
tadityar wants to merge 4 commits into
rubygems:masterfrom
tadityar:add_recent_uploads_page
Closed

Add recent uploads page#1418
tadityar wants to merge 4 commits into
rubygems:masterfrom
tadityar:add_recent_uploads_page

Conversation

@tadityar
Copy link
Copy Markdown
Contributor

@tadityar tadityar commented Sep 9, 2016

This PR adds a recent uploads page as suggested in #1217.

Continuing from #1238 by adding a new page instead of displaying the recent uploads in the stats page.

Recent Page Screenshot
screen shot 2016-09-11 at 1 04 57 pm

Link from the Stats page
screen shot 2016-09-10 at 4 19 01 am

@sonalkr132
Copy link
Copy Markdown
Member

Hi @tadityar. Thanks for PR 💟
Can you please remove 70ec5ac?

@tadityar tadityar force-pushed the add_recent_uploads_page branch from e3a3fc9 to 6d1806d Compare September 10, 2016 09:20
@simi
Copy link
Copy Markdown
Contributor

simi commented Sep 11, 2016

Hello! Nice feature!

I have few notes and ideas about this.

Since this is not statistic, I think it can be moved to own controller. Also @recent_uploads in controller can be cached easily, but I'm not sure if that's worth it.

Since this was moved to own page maybe the limit can be a little bigger (25?) and IMHO it will be interesting to show upload time.

@tadityar
Copy link
Copy Markdown
Contributor Author

Hi @simi! Thanks for the feedback, yeah since 'recent uploads' is not really statistic I'll move it to another controller. I don't know about the rate new gems are being uploaded to rubygems so I have no opinion about caching.

Showing upload time crossed my mind when doing this PR but since the original issue thread mentioned it being simple I didn't do it. It was before they decided to move this to a separate page though! So maybe now that we have a page just for this might as well!

@tadityar tadityar force-pushed the add_recent_uploads_page branch from 6d1806d to 5930fb8 Compare September 11, 2016 05:03
@simi
Copy link
Copy Markdown
Contributor

simi commented Sep 11, 2016

@tadityar to get idea how often are gems pushed you can inspect https://twitter.com/rubygems. I'm not sure how performing the current SQL query is. Let me try to find out using real data set.

@homu
Copy link
Copy Markdown
Contributor

homu commented Jan 8, 2017

☔ The latest upstream changes (presumably #1522) made this pull request unmergeable. Please resolve the merge conflicts.

@arthurnn
Copy link
Copy Markdown
Member

I don't know how real time those pages need to be.
If the query is a bit slow, but we still can execute it, I am OK with this, and we could push that page under a cached version with a expiring time of 5 minutes?

@jvanbaarsen
Copy link
Copy Markdown
Contributor

@tadityar Are you still working on this? I think it would be a nice feature to have!

@sonalkr132
Copy link
Copy Markdown
Member

closing because of inactivity.

@sonalkr132 sonalkr132 closed this Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants