Skip to content

Return empty array at dependency endpoint if gem is not found #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dwradcliffe merged 1 commit into from
May 22, 2016
Merged

Return empty array at dependency endpoint if gem is not found #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/models/gem_dependent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ def fetch_dependencies
private

def fetch_dependency_from_db(gem_name)
gem_record = Rubygem.includes(:versions).find_by_name!(gem_name)
gem_record = Rubygem.includes(:versions).find_by_name(gem_name)
return [] unless gem_record
gem_record.versions.includes(:dependencies).sort_by(&:number).reverse_each.map do |version|
version_deps = version.dependencies.select { |d| d.scope == 'runtime' }

Expand Down
6 changes: 6 additions & 0 deletions test/unit/gem_dependent_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,10 @@ class GemDependentTest < ActiveSupport::TestCase
)
end
end

context "with gem_names which do not exist" do
should "return empty array" do
assert_equal [], GemDependent.new(["does_not_exist"]).to_a
end
end
end