Skip to content

Remove yanked versions from reverse_dependencies #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sferik merged 1 commit into from
Nov 10, 2015
Merged

Remove yanked versions from reverse_dependencies #1104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class Version < ActiveRecord::Base

def self.reverse_dependencies(name)
joins(dependencies: :rubygem)
.indexed
.where(rubygems: { name: name })
end

Expand Down
4 changes: 4 additions & 0 deletions test/factories.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,10 @@
rubygem
size 1024
sha256 "tdQEXD9Gb6kf4sxqvnkjKhpXzfEE96JucW4KHieJ33g="

trait :yanked do
indexed false
end
end

factory :version_history do
Expand Down
8 changes: 7 additions & 1 deletion test/unit/rubygem_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,14 @@ class RubygemTest < ActiveSupport::TestCase
@gem_two = create(:rubygem)
@gem_three = create(:rubygem)
@gem_four = create(:rubygem)
@gem_five = create(:rubygem)
@version_one_latest = create(:version, rubygem: @gem_one, number: '0.2')
@version_one_earlier = create(:version, rubygem: @gem_one, number: '0.1')
@version_two_latest = create(:version, rubygem: @gem_two, number: '1.0')
@version_two_earlier = create(:version, rubygem: @gem_two, number: '0.5')
@version_three = create(:version, rubygem: @gem_three, number: '1.7')
@version_four = create(:version, rubygem: @gem_four, number: '3.9')
@version_five = create(:version, :yanked, rubygem: @gem_five, number: '6.66')

@version_one_latest.dependencies << create(:dependency,
version: @version_one_latest,
Expand All @@ -215,9 +217,12 @@ class RubygemTest < ActiveSupport::TestCase
@version_three.dependencies << create(:dependency,
version: @version_three,
rubygem: @dep_rubygem)
@version_five.dependencies << create(:dependency,
version: @version_five,
rubygem: @dep_rubygem)
end

should "return all depended rubygems" do
should "return all depended rubygems except yanked versions" do
gem_list = Rubygem.reverse_dependencies(@dep_rubygem.name)

assert_equal 3, gem_list.size
Expand All @@ -226,6 +231,7 @@ class RubygemTest < ActiveSupport::TestCase
assert gem_list.include?(@gem_two)
assert gem_list.include?(@gem_three)
assert !gem_list.include?(@gem_four)
assert !gem_list.include?(@gem_five)
end
end

Expand Down