Conversation
| source "https://rubygems.org/" | ||
|
|
||
| # a modular Ruby webserver interface | ||
| gem "rack" |
There was a problem hiding this comment.
It would be good to have a lot more examples that reflect more real-world Gemfiles and how this command modifies them:
- How does this work on really large Gemfiles?
- How does it handle comments inside a Gemfile?
- How does it handle Gemfiles that have ruby code inside it?
There was a problem hiding this comment.
Currently, it only works well for a standard Gemfile.
text/0000-bundle-canonical.md
Outdated
|
|
||
| # Summary | ||
|
|
||
| Add a new `bundle canonical` feature. The `bundle canonical` command will modify the gemfile by giving it consistent formatting and beautify it by addign summary of the gems if required. |
text/0000-bundle-canonical.md
Outdated
| gem "rack" | ||
| ``` | ||
|
|
||
| Adding `--view` option does not change the Gemfile rather shows what the Gemfile would look like if run without `--view`. |
There was a problem hiding this comment.
IMO --dry-run or --dry would be better to name this functionality
There was a problem hiding this comment.
--dry-run would be fine, I think
text/0000-bundle-canonical.md
Outdated
|
|
||
| # Summary | ||
|
|
||
| Add a new `bundle canonical` feature. The `bundle canonical` command will modify the gemfile by giving it consistent formatting and beautify it by addign summary of the gems if required. |
There was a problem hiding this comment.
consistent formatting
I suggest expanding on what "consistent formatting" is and define what that looks and why it should be that way.
94f5eb3 to
e0b0de4
Compare
|
I'm not sure this is worth adding to
To elaborate a bit further on this: Given the level of configurabily |
|
We should probably come up with a decision here. |
|
I'm happy to leave this to |
Rendered