This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Backport GemHelper changes for #7108#7109
Merged
colby-swandale merged 1 commit into2-0-stablefrom Apr 9, 2019
Merged
Conversation
deivid-rodriguez
approved these changes
Apr 8, 2019
Contributor
deivid-rodriguez
left a comment
deivid-rodriguez
left a comment
There was a problem hiding this comment.
This looks good to me, and a smart resort to fix the backport difficulties. Nicely done 👍
Member
Author
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 9, 2019
7109: Backport `GemHelper` changes for #7108 r=colby-swandale a=colby-swandale I'm working on getting #7108 into the v2.0.2 release but that code has not been kept up to date over time (i'm not sure why i haven't been doing this). Trying to cherry-pick the changes to `GemHelper` is proving to be not super fun to deal with. Instead, i'm just going to copy/paste the current file & specs into `2-0-stable` There doesn't seem to be any breaking changes, so this should be ok to perform. Co-authored-by: Colby Swandale <me@colby.fyi>
Timed out |
Member
Author
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 9, 2019
7109: Backport `GemHelper` changes for #7108 r=colby-swandale a=colby-swandale I'm working on getting #7108 into the v2.0.2 release but that code has not been kept up to date over time (i'm not sure why i haven't been doing this). Trying to cherry-pick the changes to `GemHelper` is proving to be not super fun to deal with. Instead, i'm just going to copy/paste the current file & specs into `2-0-stable` There doesn't seem to be any breaking changes, so this should be ok to perform. Co-authored-by: Colby Swandale <me@colby.fyi>
Timed out |
Contributor
|
Maybe this times out because there's no bors configuration on this branch? |
Member
Author
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 9, 2019
7109: Backport `GemHelper` changes for #7108 r=colby-swandale a=colby-swandale I'm working on getting #7108 into the v2.0.2 release but that code has not been kept up to date over time (i'm not sure why i haven't been doing this). Trying to cherry-pick the changes to `GemHelper` is proving to be not super fun to deal with. Instead, i'm just going to copy/paste the current file & specs into `2-0-stable` There doesn't seem to be any breaking changes, so this should be ok to perform. Co-authored-by: Colby Swandale <me@colby.fyi>
Member
Author
|
@bundlerbot r+ |
|
Not awaiting review |
Member
Author
|
@bundlerbot retry |
|
Not awaiting review |
Member
Author
|
I don't really have time to worry about Bors, i'm just going to merge this with Github. |
Timed out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on getting #7108 into the v2.0.2 release but that code has not been kept up to date over time (i'm not sure why i haven't been doing this). Trying to cherry-pick the changes to
GemHelperis proving to be not super fun to deal with. Instead, i'm just going to copy/paste the current file & specs into2-0-stableThere doesn't seem to be any breaking changes, so this should be ok to perform.