This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Merged
Conversation
The previous logic is unclear to me. It seemed to try to detect only "multiple gemfile situations", but it was doing it incorrectly, I think. The new message is printed _only_ if both gems.rb and Gemfile are detected in the same project. And recommends sticking with gems.rb. But we are not yet deprecating "Gemfile" other than that.
deivid-rodriguez
changed the title
deivid-rodriguez
changed the title
5 tasks
Merged
Contributor
Author
|
I'm doing this for the sake of moving forward, but feel free to leave feedback after merge and I'll change anything that's needed! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 12, 2019
6999: Fix multiple gem files deprecation r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was the current message about deprecating `Gemfile` in favor of `gems.rb` was incorrect, and this I'm not sure when it was supposed to be displayed. Its corresponding test was also failing. ### What was your diagnosis of the problem? My diagnosis was that the intention was not to deprecate Gemfile's for the time being, but only warn if the user opts in to `gems.rb` but does not remove the old `Gemfile`. ### What is your fix for the problem, implemented in this PR? My fix is to properly detect the situation where both `Gemfile` and `gems.rb` files are present, and show proper messages guiding the user to properly make the switch. ### Why did you choose this fix out of the possible options? I chose this fix because I think it works and doesn't take this migration too far, since the ecosystem is not yet ready for this at all. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was the current message about deprecating
Gemfilein favor ofgems.rbwas incorrect, and this I'm not sure when it was supposed to be displayed. Its corresponding test was also failing.What was your diagnosis of the problem?
My diagnosis was that the intention was not to deprecate Gemfile's for the time being, but only warn if the user opts in to
gems.rbbut does not remove the oldGemfile.What is your fix for the problem, implemented in this PR?
My fix is to properly detect the situation where both
Gemfileandgems.rbfiles are present, and show proper messages guiding the user to properly make the switch.Why did you choose this fix out of the possible options?
I chose this fix because I think it works and doesn't take this migration too far, since the ecosystem is not yet ready for this at all.