This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Merged
Conversation
5 tasks
simi
reviewed
Feb 22, 2019
|
Why are VCR files enclosed in this PR? |
Contributor
Author
|
@shushugah I could've removed the realworld specs that were specific to old rubies, but I ended up adding them to the current suite instead. The VCR files are the result of the API responses recorded by those tests. I did this because I thought maybe it was worth running these high level specs in our test suite (even if they test cases that only been problematic on old rubies). But I'm not really sure, I guess we could just remove them. |
Since the current master will never run those rubies.
deivid-rodriguez
force-pushed
the
remove_unnecessary_ruby_filters
branch
2 times, most recently
from
c063649 to
911fe33
Compare
deivid-rodriguez
force-pushed
the
remove_unnecessary_ruby_filters
branch
from
911fe33 to
0842783
Compare
Contributor
Author
|
Finally went ahead and removed that too, so no VCR files included in this PR anymore. |
Contributor
Author
|
@bundlerbot r=colby-swandale |
ghost
pushed a commit
that referenced
this pull request
Feb 24, 2019
6983: Remove unnecessary ruby filters r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was there's a lot of unnecessary code, specially in specs, that's never run. ### What was your diagnosis of the problem? My diagnosis was that since dropping support for old ruby versions, this code is no longer necessary. ### What is your fix for the problem, implemented in this PR? My fix is to remove the code. ### Why did you choose this fix out of the possible options? I chose this fix because red is great on diffs. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Jul 15, 2019
7239: Fully remove compatibility guard r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that this code is untested and never run. ### What was your diagnosis of the problem? My diagnosis was that we can remove it. ### What is your fix for the problem, implemented in this PR? My fix is to remove the code. ### Why did you choose this fix out of the possible options? I actually intented to remove this in #6983, but after a discussing it with @simi I decided to keep it (see #6983 (comment)). After a second though I think this is safe to remove and that the potential use case (that the latest bundler is allowed to be installed by a really really old rubygems that didn't support ruby version constraints) is not a problem. The `required_ruby_version` constraint landed in [rubygems 0.6, 15 years ago](ruby/rubygems@240a9d3). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
ghost
pushed a commit
to ruby/rubygems
that referenced
this pull request
Mar 11, 2020
7239: Fully remove compatibility guard r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that this code is untested and never run. ### What was your diagnosis of the problem? My diagnosis was that we can remove it. ### What is your fix for the problem, implemented in this PR? My fix is to remove the code. ### Why did you choose this fix out of the possible options? I actually intented to remove this in rubygems/bundler#6983, but after a discussing it with @simi I decided to keep it (see rubygems/bundler#6983 (comment)). After a second though I think this is safe to remove and that the potential use case (that the latest bundler is allowed to be installed by a really really old rubygems that didn't support ruby version constraints) is not a problem. The `required_ruby_version` constraint landed in [rubygems 0.6, 15 years ago](240a9d3). Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was there's a lot of unnecessary code, specially in specs, that's never run.
What was your diagnosis of the problem?
My diagnosis was that since dropping support for old ruby versions, this code is no longer necessary.
What is your fix for the problem, implemented in this PR?
My fix is to remove the code.
Why did you choose this fix out of the possible options?
I chose this fix because red is great on diffs.