This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Merged
Conversation
5 tasks
Bundler 2 can't be installed on these rubygems, so it's not necessary.
deivid-rodriguez
force-pushed
the
remove_unnecessary_rubygems_filters
branch
from
8ef18fd to
b9ad218
Compare
Member
|
Seems good. |
hsbt
approved these changes
Feb 26, 2019
Contributor
Author
|
@bundlerbot r=hsbt |
ghost
pushed a commit
that referenced
this pull request
Feb 26, 2019
6982: Remove unnecessary rubygems filters r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was there's a lot of unnecessary code, specially in specs, that's never run. ### What was your diagnosis of the problem? My diagnosis was that since dropping support for old rubygems versions, this code is no longer necessary. ### What is your fix for the problem, implemented in this PR? My fix is to remove the code. ### Why did you choose this fix out of the possible options? I chose this fix because red is great on diffs. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was there's a lot of unnecessary code, specially in specs, that's never run.
What was your diagnosis of the problem?
My diagnosis was that since dropping support for old rubygems versions, this code is no longer necessary.
What is your fix for the problem, implemented in this PR?
My fix is to remove the code.
Why did you choose this fix out of the possible options?
I chose this fix because red is great on diffs.