This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Merged
Conversation
6834: Allow files other than Gemfile.lock to be opened in definition specs r=hsbt a=segiddins ### What was the end-user problem that led to this PR? The problem was the specs are brittle. ### What was your diagnosis of the problem? My diagnosis was we should assume code can open other files. ### What is your fix for the problem, implemented in this PR? My fix allows other files to be opened, and only raises when opening the file under test. Co-authored-by: Samuel Giddins <segiddins@segiddins.me> (cherry picked from commit cca1f63)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
I found the missing commit different with 1-17-stable.
Why did you choose this fix out of the possible options?
I picked 5fb389d from master branch.