This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Include URL in Bundler::Fetcher::FallbackError message for Net::HTTPNotFound#6864
Merged
2 commits merged intomasterfrom Jan 15, 2019
Merged
Include URL in Bundler::Fetcher::FallbackError message for Net::HTTPNotFound#68642 commits merged intomasterfrom
2 commits merged intomasterfrom
Conversation
deivid-rodriguez
approved these changes
Jan 3, 2019
Contributor
|
Can you add a spec that makes sure that passwords are removed from the URI in the error message? |
Contributor
Author
|
Good shout - updated! The CI failure on ruby-head is hopefully unrelated... |
Contributor
|
Nice! |
ghost
pushed a commit
that referenced
this pull request
Jan 15, 2019
6864: Include URL in Bundler::Fetcher::FallbackError message for Net::HTTPNotFound r=segiddins a=greysteil ### What was the end-user problem that led to this PR? It was really painful to debug persistent NotFound errors, as it wasn't clear where they were coming from, ### What was your diagnosis of the problem? Bundler was obfuscating the URL that wasn't found unnecessarily. ### What is your fix for the problem, implemented in this PR? My fix is to add the URL to the `Bundler::Fetcher::FallbackError` message for `Net::HTTPNotFound` errors. ### Why did you choose this fix out of the possible options? I chose this fix because it was simple and easy to test. Co-authored-by: Grey Baker <greysteil@gmail.com>
Build succeeded |
ghost
merged commit 
colby-swandale
pushed a commit
that referenced
this pull request
Apr 4, 2019
6864: Include URL in Bundler::Fetcher::FallbackError message for Net::HTTPNotFound r=segiddins a=greysteil ### What was the end-user problem that led to this PR? It was really painful to debug persistent NotFound errors, as it wasn't clear where they were coming from, ### What was your diagnosis of the problem? Bundler was obfuscating the URL that wasn't found unnecessarily. ### What is your fix for the problem, implemented in this PR? My fix is to add the URL to the `Bundler::Fetcher::FallbackError` message for `Net::HTTPNotFound` errors. ### Why did you choose this fix out of the possible options? I chose this fix because it was simple and easy to test. Co-authored-by: Grey Baker <greysteil@gmail.com> (cherry picked from commit 4557124)
colby-swandale
pushed a commit
that referenced
this pull request
Jun 13, 2019
* 2-0-stable: (89 commits) fix changelog 2.0.2 typos add v2.0.2 changelog bump version to 2.0.2 Merge #7199 fix bug where bundler v3 is running a test for bundflet 2 Merge #6798 add bors configuation port GemHelper from master Merge #7080 Merge #7089 Merge #7068 Merge #7036 Merge #7067 change Bundler 3 specs in travis to use RubyGems 3.0.3 bump RubyGems v3 to the latest version on Travis Merge #6963 Merge #7078 Merge pull request #7061 from bundler/fix_circular_requires Merge #6864 remove linting step in travis (it will still run in each build) ...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
It was really painful to debug persistent NotFound errors, as it wasn't clear where they were coming from,
What was your diagnosis of the problem?
Bundler was obfuscating the URL that wasn't found unnecessarily.
What is your fix for the problem, implemented in this PR?
My fix is to add the URL to the
Bundler::Fetcher::FallbackErrormessage forNet::HTTPNotFounderrors.Why did you choose this fix out of the possible options?
I chose this fix because it was simple and easy to test.