This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Removed jobs with old ruby versions from Travis CI.#6763
Closed
hsbt wants to merge 5 commits into2-0-stablefrom
Closed
Removed jobs with old ruby versions from Travis CI.#6763hsbt wants to merge 5 commits into2-0-stablefrom
hsbt wants to merge 5 commits into2-0-stablefrom
Conversation
Contributor
|
Oh my god, it's happening!! 🎉 🎉 Should we target this to master, and then backport it? |
Contributor
|
Well, there's not much to add to master other than removing the 1.8.7 entry I guess, so separate PR's make more sense since you're branching 2-0-stable off 1-17-stable. Disregard my previous comment, it's ok like this! |
Contributor
|
I have a question though, master supports |
colby-swandale
approved these changes
Oct 29, 2018
Member
colby-swandale
left a comment
colby-swandale
left a comment
There was a problem hiding this comment.
It's sooo small now! 😮 🎉
Member
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Oct 29, 2018
6763: Removed jobs with old ruby versions from Travis CI. r=colby-swandale a=hsbt I removed the ruby versions under the Ruby 2.2. We need to fix gemspec and other parameters of .travis.yml. But this is the first step of Bundler-2.0.0 reboot. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
Member
Author
|
@deivid-rodriguez I removed Ruby 2.2 and picked some jobs from the master branch 👍 |
Member
|
Because Bundler 2 has not been released yet, we're still accepting PRs for Bundler 1 and this shouldn't be merged into |
Member
|
Ah, |
colby-swandale
pushed a commit
that referenced
this pull request
Oct 29, 2018
6763: Removed jobs with old ruby versions from Travis CI. r=colby-swandale a=hsbt I removed the ruby versions under the Ruby 2.2. We need to fix gemspec and other parameters of .travis.yml. But this is the first step of Bundler-2.0.0 reboot. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org> (cherry picked from commit 67771c0)
Timed out |
ghost
pushed a commit
that referenced
this pull request
Oct 29, 2018
6764: Remove unnecessary stuff from specs r=colby-swandale a=deivid-rodriguez I wrote this patch a while ago but I didn't propose it because I didn't think it would be accepted. Now I think we're ready. ### What was the end-user problem that led to this PR? The problem was that the specs have a lot of conditional behavior on `Gem::VERSION`. ### What was your diagnosis of the problem? My diagnosis was that this was necessary because of testing against a big range of rubygems versions on the latest stable branch. ### What is your fix for the problem, implemented in this PR? My fix is to remove all the conditionals since we'll no longer test against rubygems versions that old on the latest stable, once #6763 lands. ### Why did you choose this fix out of the possible options? I chose this fix because it makes test code simpler. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
colby-swandale
force-pushed
the
2-0-stable
branch
from
e4b497a to
56a4bb8
Compare
colby-swandale
pushed a commit
that referenced
this pull request
Nov 3, 2018
6763: Removed jobs with old ruby versions from Travis CI. r=colby-swandale a=hsbt I removed the ruby versions under the Ruby 2.2. We need to fix gemspec and other parameters of .travis.yml. But this is the first step of Bundler-2.0.0 reboot. Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org> (cherry picked from commit 67771c0)
Member
Author
|
This pull request has been merged at 9ecc86f |
colby-swandale
pushed a commit
that referenced
this pull request
Mar 23, 2019
6764: Remove unnecessary stuff from specs r=colby-swandale a=deivid-rodriguez I wrote this patch a while ago but I didn't propose it because I didn't think it would be accepted. Now I think we're ready. The problem was that the specs have a lot of conditional behavior on `Gem::VERSION`. My diagnosis was that this was necessary because of testing against a big range of rubygems versions on the latest stable branch. My fix is to remove all the conditionals since we'll no longer test against rubygems versions that old on the latest stable, once #6763 lands. I chose this fix because it makes test code simpler. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 27ab011)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the ruby versions under the Ruby 2.2. We need to fix gemspec and other parameters of .travis.yml. But this is the first step of Bundler-2.0.0 reboot.