Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Support Windows platform with ruby core repository.#6741

Merged
1 commit merged intomasterfrom
support-windows
Oct 16, 2018
Merged

Support Windows platform with ruby core repository.#6741
1 commit merged intomasterfrom
support-windows

Conversation

@hsbt
Copy link
Copy Markdown
Member

@hsbt hsbt commented Oct 16, 2018

What was the end-user problem that led to this PR?

In Windows environment, ':' is always contained path variable.

See our original commit and its message

ruby/ruby@f35fb6d

@colby-swandale
Copy link
Copy Markdown
Member

Thanks! @bundlerbot r+

@hsbt
Copy link
Copy Markdown
Member Author

hsbt commented Oct 16, 2018

@bundlerbot r+

ghost pushed a commit that referenced this pull request Oct 16, 2018
6741: Support Windows platform with ruby core repository. r=hsbt a=hsbt

### What was the end-user problem that led to this PR?

In Windows environment, ':' is always contained path variable.

See our original commit and its message 

ruby/ruby@f35fb6d



Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
@ghost
Copy link
Copy Markdown

ghost commented Oct 16, 2018

Build succeeded

@ghost ghost merged commit c209b96 into master Oct 16, 2018
@hsbt hsbt added this to the 1.17.0 milestone Oct 17, 2018
@hsbt hsbt deleted the support-windows branch October 17, 2018 12:47
@hsbt hsbt modified the milestones: 1.17.0, 2.0.0 Oct 25, 2018
colby-swandale pushed a commit that referenced this pull request Oct 29, 2018
6741: Support Windows platform with ruby core repository. r=hsbt a=hsbt

In Windows environment, ':' is always contained path variable.

See our original commit and its message

ruby/ruby@f35fb6d

Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
(cherry picked from commit 3a69ee3)
colby-swandale pushed a commit that referenced this pull request Oct 29, 2018
6741: Support Windows platform with ruby core repository. r=hsbt a=hsbt

In Windows environment, ':' is always contained path variable.

See our original commit and its message

ruby/ruby@f35fb6d

Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
(cherry picked from commit 3a69ee3)
hsbt added a commit that referenced this pull request Nov 10, 2018
6741: Support Windows platform with ruby core repository. r=hsbt a=hsbt

In Windows environment, ':' is always contained path variable.

See our original commit and its message

ruby/ruby@f35fb6d

Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
(cherry picked from commit 3a69ee3)
hsbt added a commit that referenced this pull request Jan 4, 2019
6741: Support Windows platform with ruby core repository. r=hsbt a=hsbt

In Windows environment, ':' is always contained path variable.

See our original commit and its message

ruby/ruby@f35fb6d

Co-authored-by: SHIBATA Hiroshi <hsbt@ruby-lang.org>
(cherry picked from commit 3a69ee3)
hsbt added a commit that referenced this pull request Jan 4, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants