This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Check for file or folder when checking for git hash in build metadata#6733
Merged
1 commit merged intomasterfrom Oct 12, 2018
Merged
Check for file or folder when checking for git hash in build metadata#67331 commit merged intomasterfrom
1 commit merged intomasterfrom
Conversation
colby-swandale
force-pushed
the
colby/fix-rubygems-spec-suite
branch
from
9823679 to
938938f
Compare
greysteil
approved these changes
Oct 11, 2018
Contributor
|
@colby-swandale - will the |
Member
Author
|
Yes, it will return a hash (although it's RubyGem's git hash) |
Contributor
|
Cool, that still sounds useful. 👍 from me. |
Member
Author
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Oct 12, 2018
6733: Check for file or folder when checking for git hash in build metadata r=colby-swandale a=colby-swandale Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? A change that was introduced in #6664 is breaking RubyGem's specs because the Build Metadata is not being generated correctly. This is breaking because the change is checking for the `.git` to determine if the git hash should be fetched for the version string. This folder does not exist in the submodule in RubyGems' repo ### What was your diagnosis of the problem? See https://travis-ci.org/rubygems/rubygems/jobs/437576972 ### What is your fix for the problem, implemented in this PR? Check if `.git` exists either as a file or folder Co-authored-by: Colby Swandale <me@colby.fyi>
Build succeeded |
ghost
merged commit 
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.
What was the end-user problem that led to this PR?
A change that was introduced in #6664 is breaking RubyGem's specs because the Build Metadata is not being generated correctly.
This is breaking because the change is checking for the
.gitto determine if the git hash should be fetched for the version string. This folder does not exist in the submodule in RubyGems' repoWhat was your diagnosis of the problem?
See https://travis-ci.org/rubygems/rubygems/jobs/437576972
What is your fix for the problem, implemented in this PR?
Check if
.gitexists either as a file or folder