This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Test bad rubygems binstub + locked bundler behavior#6725
Closed
deivid-rodriguez wants to merge 1 commit intomasterfrom
Closed
Test bad rubygems binstub + locked bundler behavior#6725deivid-rodriguez wants to merge 1 commit intomasterfrom
deivid-rodriguez wants to merge 1 commit intomasterfrom
Conversation
When running a rubygems bundler binstub with lock file locked to a non-installed bundler version, one would get the cryptic error message: ``` can't find gem bundler (>= 0.a) with executable bundle (Gem::GemNotFoundException) ``` where one tends to think... What? How is it not found if I just run it?!
4 tasks
deivid-rodriguez
changed the title
Contributor
Author
|
This fails, as expected, since the fix is not yet on rubygems master... |
Contributor
|
Should this test go in the rubygems repo? |
Contributor
Author
|
Yeah, most likely... |
Contributor
Author
|
Closing since I managed to write a spec in the rubygems PR that definitely feels more natural than what I'm doing here 👍. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that we have no specs to demostrate the issue in #6595, nor to prove the fix in ruby/rubygems#2426.
What was your diagnosis of the problem?
My diagnosis was that we need those specs.
What is your fix for the problem, implemented in this PR?
My fix is to write the specs. They don't look very good though... 😅.
Why did you choose this fix out of the possible options?
I chose this fix because I couldn't think of any other ways to write them.