[CLI::Gem] Add a --rubocop option by segiddins · Pull Request #6455 · rubygems/bundler

segiddins · 2018-03-25T02:21:39Z

Based upon #6451.

What was the end-user problem that led to this PR?

The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem.

What was your diagnosis of the problem?

My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in bundle gem.

What is your fix for the problem, implemented in this PR?

My fix adds an option to bundle gem to add in RuboCop, in the same way options like :cocand :mit are handled.

Why did you choose this fix out of the possible options?

I chose this fix because it does not require bundler have an opinion on how rubocop is configured.

colby-swandale · 2018-04-15T01:12:56Z

Great!! @bundlerbot r+

bundlerbot · 2018-04-15T01:12:57Z

📌 Commit d3275e8 has been approved by colby-swandale

bundlerbot · 2018-04-15T01:13:08Z

⌛ Testing commit d3275e8 with merge 5e07c2b...

…colby-swandale [CLI::Gem] Add a --rubocop option Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured.

bundlerbot · 2018-04-15T01:38:56Z

💔 Test failed - status-travis

colby-swandale · 2018-04-15T01:40:04Z

Oh, i didn't notice the failing specs

segiddins · 2018-04-15T03:20:39Z

I think this just needs a rebase?

colby-swandale · 2018-04-17T23:29:19Z

This looks like it's rebased with some other commits it shouldn't have.

segiddins · 2018-04-18T02:19:42Z

Nah I just need to rebase the other branch, I think

colby-swandale · 2018-04-18T03:14:38Z

Oh i didn't notice that this wasn't going into master.

segiddins · 2018-04-19T03:51:23Z

Rebased segiddins/bundle-gem-version-file

koic · 2018-04-19T05:10:54Z

lib/bundler/templates/newgem/VERSION

@@ -0,0 +1 @@
+0.1.0


I thought it would be better to add a newline for EOF.

bundlerbot · 2018-05-01T05:02:18Z

☔ The latest upstream changes (presumably 225c68e) made this pull request unmergeable. Please resolve the merge conflicts.

segiddins · 2018-06-04T01:36:44Z

@indirect r?

indirect · 2018-06-04T02:14:13Z

looks good, @bundlerbot r+

bundlerbot · 2018-06-04T02:14:13Z

📌 Commit 2df9564 has been approved by indirect

bundlerbot · 2018-06-04T02:14:23Z

⌛ Testing commit 2df9564 with merge 29d5f65...

…indirect [CLI::Gem] Add a --rubocop option Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured.

bundlerbot · 2018-06-04T02:42:14Z

💔 Test failed - status-travis

segiddins · 2018-06-04T02:44:14Z

@bundlerbot retry

bundlerbot · 2018-06-04T02:44:18Z

⌛ Testing commit 2df9564 with merge d2480e2...

…indirect [CLI::Gem] Add a --rubocop option Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured.

bundlerbot · 2018-06-04T03:08:51Z

💔 Test failed - status-travis

colby-swandale · 2018-07-17T12:22:22Z

@bundlerbot retry

bundlerbot · 2018-07-17T12:22:28Z

⌛ Testing commit 2df9564 with merge 6803e0e...

deivid-rodriguez · 2018-09-24T18:34:53Z

Only changes I made is pointing this PR to master, and adding some missing spaces to the CLI message.

deivid-rodriguez · 2018-09-25T11:21:08Z

1.8.7 matrix entry failed, not sure why. I restarted it.

ixti · 2018-10-05T12:17:33Z

lib/bundler/templates/newgem/newgem.gemspec.tt

 <%- end -%>
+<%- if config[:rubocop] -%>
+  spec.add_development_dependency "rubocop"
+<%- end -%>


Worth also to add rubocop-rspec if chosen test framework is rspec IMO

colby-swandale · 2018-10-09T11:10:06Z

This is going to have to wait for bundler 2 to be released before we can merge it. For some reason the ruby parser in 1.8.7 is locking up in Bundler::UI:Shell#yes?

colby-swandale · 2019-07-05T11:15:39Z

This should be ok to merge now. I can work on getting this over the line.

simi

Nice!

lib/bundler/cli/gem.rb

deivid-rodriguez · 2019-07-31T15:23:00Z

@colby-swandale, are you still planning to wrap up this PR? I can follow up if you are very busy 👍.

7373: Refactor new gem specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I rebased #6455 and I had trouble getting the specs to pass. ### What was your diagnosis of the problem? My diagnosis was that the new gemspecs could use a refactor. ### What is your fix for the problem, implemented in this PR? My fix is to refactor these specs so that they are easier to read and modify. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>

deivid-rodriguez · 2019-10-25T14:53:04Z

@colby-swandale Forgot to mention that I updated this PR and it should be finally ready, in case you want to have a look at it before merging.

7373: Refactor new gem specs r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I rebased #6455 and I had trouble getting the specs to pass. ### What was your diagnosis of the problem? My diagnosis was that the new gemspecs could use a refactor. ### What is your fix for the problem, implemented in this PR? My fix is to refactor these specs so that they are easier to read and modify. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 6ceec55)

deivid-rodriguez · 2019-11-08T20:41:57Z

@bundlerbot merge

6455: [CLI::Gem] Add a --rubocop option r=deivid-rodriguez a=segiddins Based upon #6451. ### What was the end-user problem that led to this PR? The problem was I always have to remember how to add RuboCop to my Rakefile when I set up a new gem. ### What was your diagnosis of the problem? My diagnosis was that RuboCop has become enough of a community standard that it makes sense to offer it in `bundle gem`. ### What is your fix for the problem, implemented in this PR? My fix adds an option to `bundle gem` to add in RuboCop, in the same way options like `:coc`and `:mit` are handled. ### Why did you choose this fix out of the possible options? I chose this fix because it does not require bundler have an opinion on _how_ rubocop is configured. Co-authored-by: Samuel Giddins <segiddins@segiddins.me>

ghost · 2019-11-08T21:45:17Z

Build succeeded

continuous-integration/travis-ci/push

colby-swandale added this to the 1.17.0 milestone Apr 15, 2018

segiddins force-pushed the segiddins/bundle-gem-rubocop-option branch from d3275e8 to ea6d542 Compare April 16, 2018 15:14

segiddins force-pushed the segiddins/bundle-gem-version-file branch from 880d379 to ea0a09b Compare April 19, 2018 03:49

koic reviewed Apr 19, 2018

View reviewed changes

segiddins force-pushed the segiddins/bundle-gem-version-file branch from ea0a09b to 225c68e Compare May 1, 2018 05:02

segiddins force-pushed the segiddins/bundle-gem-rubocop-option branch from ea6d542 to 2df9564 Compare May 1, 2018 05:05

ixti reviewed Oct 5, 2018

View reviewed changes

colby-swandale modified the milestones: 1.17.0, 2.0 — Breaking Changes Oct 9, 2018

colby-swandale added the type: major upgrade label Oct 17, 2018

colby-swandale removed type: major upgrade labels Nov 24, 2018

simi approved these changes Jul 12, 2019

View reviewed changes

koic reviewed Jul 12, 2019

View reviewed changes

lib/bundler/cli/gem.rb Outdated Show resolved Hide resolved

koic reviewed Jul 12, 2019

View reviewed changes

lib/bundler/cli/gem.rb Show resolved Hide resolved

deivid-rodriguez force-pushed the segiddins/bundle-gem-rubocop-option branch from 82faeba to 1d2d5b0 Compare October 2, 2019 09:02

deivid-rodriguez mentioned this pull request Oct 2, 2019

Refactor new gem specs #7373

Merged

deivid-rodriguez force-pushed the segiddins/bundle-gem-rubocop-option branch from 1d2d5b0 to 0448ad5 Compare October 3, 2019 15:17

deivid-rodriguez force-pushed the segiddins/bundle-gem-rubocop-option branch from 0448ad5 to 2210cad Compare October 12, 2019 14:45

[CLI::Gem] Add a --rubocop option

f821c75

deivid-rodriguez force-pushed the segiddins/bundle-gem-rubocop-option branch from 2210cad to f821c75 Compare October 19, 2019 18:28

deivid-rodriguez removed this from the 3.0 — Breaking Changes milestone Nov 6, 2019

ghost merged commit f821c75 into master Nov 8, 2019

ghost deleted the segiddins/bundle-gem-rubocop-option branch November 8, 2019 21:45

deivid-rodriguez mentioned this pull request Jun 19, 2020

Fix RuboCop offenses ruby/rubygems#3740

Merged

4 tasks

This pull request was closed.

Uh oh!

Conversation

segiddins commented Mar 25, 2018

What was the end-user problem that led to this PR?

What was your diagnosis of the problem?

What is your fix for the problem, implemented in this PR?

Why did you choose this fix out of the possible options?

Uh oh!

colby-swandale commented Apr 15, 2018

Uh oh!

bundlerbot commented Apr 15, 2018

Uh oh!

bundlerbot commented Apr 15, 2018

Uh oh!

bundlerbot commented Apr 15, 2018

Uh oh!

colby-swandale commented Apr 15, 2018

Uh oh!

segiddins commented Apr 15, 2018

Uh oh!

colby-swandale commented Apr 17, 2018

Uh oh!

segiddins commented Apr 18, 2018

Uh oh!

colby-swandale commented Apr 18, 2018

Uh oh!

segiddins commented Apr 19, 2018

Uh oh!

koic Apr 19, 2018

Choose a reason for hiding this comment

Uh oh!

bundlerbot commented May 1, 2018

Uh oh!

segiddins commented Jun 4, 2018

Uh oh!

indirect commented Jun 4, 2018

Uh oh!

bundlerbot commented Jun 4, 2018

Uh oh!

bundlerbot commented Jun 4, 2018

Uh oh!

bundlerbot commented Jun 4, 2018

Uh oh!

segiddins commented Jun 4, 2018

Uh oh!

bundlerbot commented Jun 4, 2018

Uh oh!

bundlerbot commented Jun 4, 2018

Uh oh!

colby-swandale commented Jul 17, 2018

Uh oh!

bundlerbot commented Jul 17, 2018

Uh oh!

deivid-rodriguez commented Sep 24, 2018

Uh oh!

deivid-rodriguez commented Sep 25, 2018

Uh oh!

ixti Oct 5, 2018

Choose a reason for hiding this comment

Uh oh!

colby-swandale commented Oct 9, 2018

Uh oh!

colby-swandale commented Jul 5, 2019

Uh oh!

simi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

deivid-rodriguez commented Jul 31, 2019

Uh oh!

deivid-rodriguez commented Oct 25, 2019

Uh oh!

deivid-rodriguez commented Nov 8, 2019

Uh oh!

ghost commented Nov 8, 2019

Build succeeded

Uh oh!

Reviewers

Assignees