[FIX] skip bundler gem when warning when an explicitly updated spec d…

[oded-zahavi]

…oes not get a newer version (618c09b)

Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.

What was the end-user problem that led to this PR?

The problem was when running bundle update --group xxx

What was your diagnosis of the problem?

My diagnosis was that bundler was taken into consideration and fails the updating process

What is your fix for the problem, implemented in this PR?

My fix is to skip bundler when checking whether to warn when an explicitly updated spec does not get a newer version

Why did you choose this fix out of the possible options?

I chose this fix because it is a rather new code (added in v1.16.0) and it is rather simple and doesn't require lots of changes in code. Another option would be to revert the lines added between 1.15.4 and 16.0.0 altogether. Up to the maintainers to decide.

[ghost]

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

[colby-swandale]

Thanks for opening a pull request, we will need a test for this change to make sure we don't regress in the future.

[bundlerbot]

☔ The latest upstream changes (presumably #6157) made this pull request unmergeable. Please resolve the merge conflicts.

[segiddins]

Looks good with an added test case!

[oded-zahavi]

Thanks @segiddins any plans to merge any time soon?

[colby-swandale]

@oded-zahavi This still requires a test and this also needs to rebase with master before we merge.

[oded-zahavi]

Imho it shouldn't have passed previous CI because the bug was actually inserted in 0.16.0. Working like a charm in 0.15.4 Anyways - Should I write tests of should it pass your tests?

…

On Thu, Nov 16, 2017 at 9:54 PM, Colby Swandale ***@***.***> wrote: @oded-zahavi <https://github.com/oded-zahavi> This still requires a test and this also needs to rebase with master before we merge. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6155 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARMa1ROjepRPMzKbFV0q1qJqLI3MgK1Kks5s3JLbgaJpZM4QUseX> .

[segiddins]

Yes, please add a test so we don't regress in the future

[colby-swandale]

ping @oded-zahavi