This repository was archived by the owner on Apr 14, 2021. It is now read-only.
update Rubocop target ruby version to 2.3#6039
Closed
colby-swandale wants to merge 1 commit intomasterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
Rubocop is configured to parse ruby files in the bundler project with Ruby 1.9 syntax. Ruby 2.3 is now officially the min version required in master so this can bumped
What was your diagnosis of the problem?
Rubocop is being explicitly set to parse the bundler project as ruby 1.9. Which can be found here
What is your fix for the problem, implemented in this PR?
Set the new target ruby version value to 2.3