This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] [Resolver] Use the GVP for major updates in 2.0#5995
Merged
bundlerbot merged 3 commits intomasterfrom Sep 5, 2017
Merged
[2.0] [Resolver] Use the GVP for major updates in 2.0#5995bundlerbot merged 3 commits intomasterfrom
bundlerbot merged 3 commits intomasterfrom
Conversation
Contributor
Author
|
This seems to break |
This way, it can be reset in #missing_specs?
Contributor
Author
|
This ought to pass now! r? |
segiddins
force-pushed
the
seg-gvp-major
branch
from
90b8722 to
092dfb6
Compare
|
@bundlerbot r+ |
Collaborator
|
📌 Commit 092dfb6 has been approved by |
Collaborator
bundlerbot
added a commit
that referenced
this pull request
Sep 5, 2017
[2.0] [Resolver] Use the GVP for major updates in 2.0 Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? The problem was @chrismo wants to start delegating all sorting to the GVP. ### What was your diagnosis of the problem? My diagnosis was to start doing that in 2.0. Closes #5993 ### What is your fix for the problem, implemented in this PR? My fix adds a feature flag.
Collaborator
|
☀️ Test successful - status-travis |
This was referenced Sep 5, 2017
Contributor
|
thx a bunch @segiddins |
colby-swandale
pushed a commit
that referenced
this pull request
Sep 22, 2018
[2.0] [Resolver] Use the GVP for major updates in 2.0 Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. The problem was @chrismo wants to start delegating all sorting to the GVP. My diagnosis was to start doing that in 2.0. Closes #5993 My fix adds a feature flag. (cherry picked from commit a325b6d)
colby-swandale
pushed a commit
that referenced
this pull request
Sep 22, 2018
[2.0] [Resolver] Use the GVP for major updates in 2.0 Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. The problem was @chrismo wants to start delegating all sorting to the GVP. My diagnosis was to start doing that in 2.0. Closes #5993 My fix adds a feature flag. (cherry picked from commit a325b6d)
colby-swandale
pushed a commit
that referenced
this pull request
Oct 5, 2018
[2.0] [Resolver] Use the GVP for major updates in 2.0 Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. The problem was @chrismo wants to start delegating all sorting to the GVP. My diagnosis was to start doing that in 2.0. Closes #5993 My fix adds a feature flag. (cherry picked from commit a325b6d)
colby-swandale
pushed a commit
that referenced
this pull request
Oct 25, 2018
* 1-17-stable: (38 commits) Version 1.17.0 with changelog Merge #6754 Version 1.17.0.pre.2 with changelog fix failing bundle remove specs Still document the `--force` option scope specs testing bundler 2 deprecations to bundler 1 only Merge #6718 Merge #6707 Merge #6702 Merge #6316 Auto merge of #6447 - agrim123:agr-update-error-message, r=segiddins Auto merge of #6513 - agrim123:agr-bundler-remove, r=indirect Auto merge of #6318 - jhawthorn:fix_incorrect_test_in_requires_sudo, r=segiddins Auto merge of #6450 - bundler:segiddins/bundle-binstubs-all, r=colby-swandale Auto merge of #6024 - gwerbin:custom-user-bundle-dir, r=colby-swandale Version 1.17.0.pre.1 with changelog Auto merge of #5964 - bundler:colby/deprecate-viz-command, r=segiddins Auto merge of #5986 - bundler:seg-jobs-count, r=indirect Auto merge of #5995 - bundler:seg-gvp-major, r=indirect Auto merge of #5803 - igorbozato:path_relative_to_pwd, r=indirect ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.
What was the end-user problem that led to this PR?
The problem was @chrismo wants to start delegating all sorting to the GVP.
What was your diagnosis of the problem?
My diagnosis was to start doing that in 2.0.
Closes #5993
What is your fix for the problem, implemented in this PR?
My fix adds a feature flag.