This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Settings] Allow configuring a mirror fallback timeout without a trailing slash #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,7 +118,7 @@ class MirrorConfig | |||
|
|
|||
| def initialize(config_line, value) | |||
| uri, fallback = | |||
| config_line.match(%r{^mirror\.(all|.+?)(\.fallback_timeout)?\/?$}).captures | |||
| config_line.match(%r{\Amirror\.(all|.+?)(\.fallback_timeout)?\/?\z}).captures | |||
There was a problem hiding this comment.
out of curiosity what's the reason for this change?
There was a problem hiding this comment.
preference -- I don't like using ^$ since they're relative to a line, rather than the whole string
colby-swandale
approved these changes
Apr 25, 2017
|
@bundlerbot r+ |
|
📌 Commit f4fb8cb has been approved by |
indirect
approved these changes
Apr 27, 2017
bundlerbot
added a commit
that referenced
this pull request
Apr 27, 2017
…ndirect [Settings] Allow configuring a mirror fallback timeout without a trailing slash Closes #4830
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4830