Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add bundle issue command that prints instructions for reporting issues #5505

Merged
merged 4 commits into from
Apr 5, 2017

Conversation

jonathanpike
Copy link
Contributor

This is my stab at adding a bundle issue command, as listed in the list of tasks anyone can claim (#4871). This is also my first contribution (of what I hope will be many) to Bundler!

I hope that this is useful, and please let me know how to improve it!

@colby-swandale
Copy link
Member

Thanks! This looks promising but checkout bundler/rfcs#5 for ideas we have for the issue command.

@indirect
Copy link
Member

This is awesome, thanks for sending it! Thanks for submitting this! I think this is a great first step 👍

@colby-swandale @segiddins I'd like to propose that we accept many small PRs that each handle one aspect of the overall issues RFC, rather than requiring a single giant PR that implements the entire thing. How do you feel about that?

@colby-swandale
Copy link
Member

colby-swandale commented Mar 12, 2017

@indirect makes sense, i can count about 4 different RFCs inside rfc#5

@jonathanpike
Copy link
Contributor Author

@colby-swandale thanks for pointing out rfc#5. Prior to submitting this PR, I did look around for further discussion about this feature but I guess I missed this.

From what the rfc lays out, it looks like the final version of bundle issue is more of an automated issue reporting solution, but that isn't fully discussed yet. Since a lot of it looks still up for discussion, is there anything else that would be helpful for me to add to this PR to make it closer to what the final version should be?

@colby-swandale
Copy link
Member

Checkout the bundle env command, we probably will want to include the contents of the Gemfile and Gemfile.lock

@jonathanpike
Copy link
Contributor Author

@colby-swandale I'm already including Env#report, but I didn't provide the print_gemfile option. I'll update that. Anything else?

@colby-swandale
Copy link
Member

@indirect @segiddins Do we want to update ISSUES.md to inform users to use bundler issue instead from now on?

@indirect
Copy link
Member

@colby-swandale I think we'll want to wait to update the docs until this is merged and in a release, but it seems good to do it then 👍

@jonathanpike
Copy link
Contributor Author

@colby-swandale Let me know if there's anything else I can add/change to move this PR along. I appreciate your help!

@segiddins segiddins requested a review from colby-swandale April 3, 2017 21:30
Copy link
Member

@colby-swandale colby-swandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small suggestions, otherwise this looks good to go.

3. Information about each Bundler command can be found in the Bundler
man pages: http://bundler.io/man/bundle.1.html

Hopefully the trouble shooting steps above resolved your problem! If things
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

troubleshooting


Hopefully the trouble shooting steps above resolved your problem! If things
still aren't working the way you expect them to, please let us know so
that we can diagnose and hopefully fix the problem you're having. Please
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would suggest something like that we can diagnose and help fix the problem you're having.

@colby-swandale
Copy link
Member

Thank you!

@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 6351c68 has been approved by colby-swandale

@bundlerbot
Copy link
Collaborator

⌛ Testing commit 6351c68 with merge 6a7262c...

bundlerbot added a commit that referenced this pull request Apr 5, 2017
Add `bundle issue` command that prints instructions for reporting issues

This is my stab at adding a `bundle issue` command, as listed in the list of tasks anyone can claim (#4871).  This is also my first contribution (of what I hope will be many) to Bundler!

I hope that this is useful, and please let me know how to improve it!
@bundlerbot
Copy link
Collaborator

☀️ Test successful - status-travis
Approved by: colby-swandale
Pushing 6a7262c to master...

@bundlerbot bundlerbot merged commit 6351c68 into rubygems:master Apr 5, 2017
@indirect indirect mentioned this pull request Apr 8, 2017
23 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants