This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[Definition] Remove no-op code in expanded_deps#5387
Closed
chrismo wants to merge 1 commit intorubygems:masterfrom
Closed
[Definition] Remove no-op code in expanded_deps#5387chrismo wants to merge 1 commit intorubygems:masterfrom
chrismo wants to merge 1 commit intorubygems:masterfrom
Conversation
While troubleshooting my bundler-fixture gem, which hacks up a Definition class with a fake Index, and needed updating for 1.14 support for ruby and RubyGems version in the Definition index, I noticed this block of code appears to not do anything, since a 2nd argument is not being passed into `concat_ruby_version_requirements` method. The specs that were altered in the same commit that added these lines pass with or without the lines of code, so I'm committing this up to do a full Travis run to see if there are any other consequences. If not, then we either can remove these lines, or need to hook them up properly and add proper failing specs.
Contributor
Author
|
@segiddins dunno if i'll get time soon to dive into this, to figure out if this code should stay and be connected properly, and what the failing spec would be for it - or if this code can just be removed. |
Contributor
|
Let's rip it out for now |
Contributor
|
Or change it to |
Contributor
|
@chrismo which approach would you prefer? |
Contributor
|
@chrismo ping |
Collaborator
|
☔ The latest upstream changes (presumably #5792) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
ping @chrismo |
Contributor
|
Closing due to no response from the author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While troubleshooting my bundler-fixture gem, which hacks up a
Definition class with a fake Index, and needed updating for 1.14
support for ruby and RubyGems version in the Definition index, I
noticed this block of code appears to not do anything, since a 2nd
argument is not being passed into
concat_ruby_version_requirementsmethod.
The specs that were altered in the same commit that added these lines
pass with or without the lines of code, so I'm committing this up to do
a full Travis run to see if there are any other consequences. If not,
then we either can remove these lines, or need to hook them up properly
and add proper failing specs.