Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

[WIP] Split gem sources in lockfile#4667

Closed
chalkos wants to merge 1 commit intorubygems:2-0-devfrom
chalkos:bf-split-gem-sources
Closed

[WIP] Split gem sources in lockfile#4667
chalkos wants to merge 1 commit intorubygems:2-0-devfrom
chalkos:bf-split-gem-sources

Conversation

@chalkos
Copy link
Copy Markdown
Contributor

@chalkos chalkos commented Jun 12, 2016

Tasklist

  • remove the rubygems aggregate
  • link every gem to a single remote, possibly by grouping multiple gems under a source and managing multiple sources
  • allow one global source that is chosen when no other source is present
  • by default, the global source is the local source
  • throw an exception when a gem could have multiple sources (see case 1 below)
  • change the lockfile format to accommodate the changes above

Case 1: When a gem may be obtained from multiple sources.

source "https://rubygems.org"
gem "rake"

source "https://sidekiq.io" do
  gem "sidekiq-pro"
end

sidekiq-pro depends on sidekiq, which is hosted on rubygems.org (and not hosted on sidekiq.io)
so the gem sidekiq has no source, and could be available from rubygems.org, sidekiq.io, or both

Solutions:

  • if it’s only available from one source, we need to lock it to that one
  • if it’s available from more than one, we need to throw an exception and tell the user that they have to tell us which source to use. Then the user edits the gemfile to something like:
source "https://rubygems.org"
gem "rake"
gem "sidekiq"

source "https://sidekiq.io" do
  gem "sidekiq-pro"
end

and this way all gems have a definite source.

@chalkos chalkos force-pushed the bf-split-gem-sources branch from 76810ed to d4257d5 Compare June 12, 2016 17:56
@chalkos
Copy link
Copy Markdown
Contributor Author

chalkos commented Jun 12, 2016

@indirect @segiddins I think that the task list covers everything we talked about. Feel free to comment/add anything else you can think of.

@segiddins
Copy link
Copy Markdown
Contributor

@chalkos how's this coming along?

@segiddins segiddins closed this Jun 24, 2016
@segiddins
Copy link
Copy Markdown
Contributor

Succeeded by #4714

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants