Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

WIP: Setup Appveyor configuration#4299

Closed
RochesterinNYC wants to merge 4 commits intorubygems:masterfrom
RochesterinNYC:setup-appveyor
Closed

WIP: Setup Appveyor configuration#4299
RochesterinNYC wants to merge 4 commits intorubygems:masterfrom
RochesterinNYC:setup-appveyor

Conversation

@RochesterinNYC
Copy link
Copy Markdown
Contributor

This is a work-in-progress PR to setup Appveyor builds for Bundler. It's a work in progress since I'm pushing stuff to the PR and experimenting/fixing errors as Appveyor reports them in the builds.

version: "{build}"
skip_tags: true
branches:
only:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs to build stable

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, gotcha. Just a heads-up, this is a work-in-progress PR since I'm pushing stuff to the PR and experimenting/fixing errors as Appveyor reports them in the builds. They do seem to support local testing in the same way you can work with Travis builds in a local container but I'd need to boot up a Windows VM so this seems easier.

@indirect
Copy link
Copy Markdown

thanks for doing this! I think I've gotten autobuilds turned off while we figure it all out.

@RochesterinNYC
Copy link
Copy Markdown
Contributor Author

@indirect, Sure, what does turning off auto-builds do exactly? Will Appveyor builds on this PR still trigger on new commits/force push?

@indirect
Copy link
Copy Markdown

I'm not sure if they will trigger automatically or not--I'm trying to keep Appveyor from failing other pull requests while we work on it here.

@RochesterinNYC
Copy link
Copy Markdown
Contributor Author

Gotcha. Was just concerned that that would disable auto-builds for this PR, but that doesn't seem to be the case. All good.

@segiddins
Copy link
Copy Markdown
Contributor

'C:\projects\bundler\bin\rake' is not recognized as an internal or external common

@RochesterinNYC
Copy link
Copy Markdown
Contributor Author

Yeah, sorry, this is still a work in progress. Is it urgent that we get the Appveyor stuff up? I'm a bit blocked/limited by how slow/low priority our free tier AppVeyor builds are. To unblock this factor, I've set up remote desktop login on the builds and will try that next. Also, might look into booting up a Windows VM or borrowing a Windows comp with powershell to try and get the setup + test suite working with the proper commands on Windows.

@segiddins
Copy link
Copy Markdown
Contributor

Nope, not urgent at all ;)

@allenzhao
Copy link
Copy Markdown
Contributor

@RochesterinNYC Just in case I'm not understanding you correctly - To run the test suite successfully on Appveyor, we can just do some "experimental work" on a Windows ENV first, since everything is basically the same?

@RochesterinNYC
Copy link
Copy Markdown
Contributor Author

@allenzhao Yes, this is essentially about getting the specs passing cleanly on a Windows machine and seeing if/what changes to the test suite are needed to make this happen.

@bundlerbot
Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #5800) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants