This repository was archived by the owner on Apr 14, 2021. It is now read-only.
[Resolver] Allow mis-matches in bundler requirements, and warn#3871
Merged
[Resolver] Allow mis-matches in bundler requirements, and warn#3871
Conversation
|
Can we avoid an extra loop over all the deps by warning around line 164? |
Contributor
Author
|
Not really, since we won't know if we've actually activated said spec at that point. |
|
Alright then, @homu r+ |
Contributor
|
📌 Commit d6d5ecc has been approved by |
homu
added a commit
that referenced
this pull request
Jul 24, 2015
[Resolver] Allow mis-matches in bundler requirements, and warn \c @smlance @indirect
Contributor
Contributor
|
💔 Test failed - status |
Contributor
Author
|
Failing spec fixed |
|
@homu r+ |
Contributor
|
📌 Commit 32dddd7 has been approved by |
homu
added a commit
that referenced
this pull request
Jul 24, 2015
[Resolver] Allow mis-matches in bundler requirements, and warn \c @smlance @indirect
Contributor
Contributor
|
💔 Test failed - status |
Contributor
Author
|
@homu retry |
homu
added a commit
that referenced
this pull request
Jul 24, 2015
[Resolver] Allow mis-matches in bundler requirements, and warn \c @smlance @indirect
Contributor
Contributor
|
☀️ Test successful - status |
bundlerbot
added a commit
that referenced
this pull request
Jun 23, 2017
…rect [2.0] Allow conflicts between bundler dependencies and the current bundler version ### What was the end-user problem that led to this PR? The problem will occur once 2.0 is released -- there are many gems that declare a `s.dependency "bundler", "~> 1.x"` dependency on bundler. This would essentially make them inoperable with Bundler 2. We want to make adopting 2.0 as pain-free as possible, so hard conflicts are a no-go. ### Was was your diagnosis of the problem? My diagnosis was that we need a way to allow conflicts on the bundler dependency once 2.0 comes out, so people can use 2.0. ### What is your fix for the problem, implemented in this PR? My fix introduces a feature flag for allowing these conflicts (enabled on 2.0), which when enabled will ignore bundler dependencies during resolution, and warn in the installer when a conflict would've occurred. ### Why did you choose this fix out of the possible options? I chose this fix because it has the minimal performance penalty with the feature flag enabled. This is mostly a port of #3871 to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\c @smlance @indirect