This repository has been archived by the owner on Nov 23, 2020. It is now read-only.
Fixed the app for new builds #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the Gemfile.lock file is not part of the source code, this app does not work when you set up a new build.
The only changes here are removing Gemfile.lock from .gitignore, adding it to the repository, and upgrading Ruby to 2.5.8. These changes allow this app to work as a new build.
This app works in production only because it has the Gemfile.lock file from 2 to 3 years ago. If this app works in your local environment without these changes, it's because you set it up 2 to 3 years ago. In both cases, the gems listed in the Gemfile.lock file are quite old. Newer gems are incompatible with Ruby 2.4.2. I guarantee that if you tried to set up this app in Travis CI or similar service right now without the changes here, it will fail.