This repository has been archived by the owner on Nov 6, 2021. It is now read-only.
Add spec to family_request.rb #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmersonManabuAraki
force-pushed
the
add-more-test-coverage-in-model-family-request
branch
3 times, most recently
from
82aee83 to
4aa9be9
Compare
benreyn
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Thanks so much for your work on this @EmersonManabuAraki! 😄 Your contribution is very appreciated. I have some notes that are mostly personal preference. If you want to address them feel free, but otherwise ill merge this PR as is once a I hear one way or the other from you. 👍
EmersonManabuAraki
force-pushed
the
add-more-test-coverage-in-model-family-request
branch
from
4aa9be9 to
bb724cb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new spec to test FamilyRequest for more test coverage
Type of change
How Has This Been Tested?
Running specs
Screenshots