Skip to content
This repository was archived by the owner on Nov 6, 2021. It is now read-only.

[WIP] Family requests test coverage increase #161

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ group :development, :test do
gem "rspec-rails", "~> 3.5"
gem "rubocop"
gem "simplecov", require: false
gem 'rails-controller-testing'
end

group :development do
Expand Down
5 changes: 5 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,10 @@ GEM
bundler (>= 1.3.0)
railties (= 5.2.2)
sprockets-rails (>= 2.0.0)
rails-controller-testing (1.0.4)
actionpack (>= 5.0.1.x)
actionview (>= 5.0.1.x)
activesupport (>= 5.0.1.x)
rails-dom-testing (2.0.3)
activesupport (>= 4.2.0)
nokogiri (>= 1.6)
Expand Down Expand Up @@ -410,6 +414,7 @@ DEPENDENCIES
puma (~> 3.11)
pundit (~> 2.0.0)
rails (~> 5.2.1)
rails-controller-testing
rspec-rails (~> 3.5)
rubocop
sass-rails (~> 5.0)
Expand Down
6 changes: 6 additions & 0 deletions spec/factories/families.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,10 @@
comments { "MyText" }
partner
end

trait(:with_child) do
after(:create) do |family|
create(:child, family: family)
end
end
end
6 changes: 6 additions & 0 deletions spec/factories/partner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -147,5 +147,11 @@
]
end
end

trait(:with_family) do
after(:create) do |partner|
create(:family, :with_child, partner: partner)
end
end
end
end
1 change: 1 addition & 0 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@
# sign_in helpers for feature specs
config.include Devise::Test::IntegrationHelpers, type: :feature
config.include Devise::Test::ControllerHelpers, type: :controller
config.include Devise::Test::IntegrationHelpers, type: :request
config.extend ControllerMacros, type: :controller
config.include FactoryBot::Syntax::Methods
end
38 changes: 38 additions & 0 deletions spec/requests/family_requests_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
require "rails_helper"

RSpec.describe "FamilyRequests", type: :request do
describe "GET /new" do
let(:partner) { create(:partner, :verified) }

it 'renders the new template' do
sign_in partner
get "/family_requests/new"
expect(response).to render_template(:new)
end
end

describe 'POST /create' do
let(:partner) { create(:partner, :verified, :with_family) }

it 'creates a new family request' do
requested_items = {"requested_items": [{"item_name": "foo", "item_id": 42, "count": 1}]}
family_request = create(:family_request, partner: partner)
stub_request(:post, diaperbank_routes.family_requests).with(
body: { family_request: family_request }.to_json,
headers: {
"Accept" => "*/*",
"Accept-Encoding" => "gzip;q=1.0,deflate;q=0.6,identity;q=0.3",
"Content-Type" => "application/json",
# NOTE(chaserx): I don't know how to include diaperbank_routes here!s
"Host" => diaperbank_routes.family_requests.host,
"User-Agent" => "Ruby",
"X-Api-Key" => ENV["DIAPERBANK_KEY"]
}
).to_return(status: 200, body: requested_items.to_json, headers: {})

sign_in partner
post "/family_requests", params: {family_request: {child_ids: partner.children.ids}}
expect(PartnerRequest.count).to eq(1)
end
end
end