Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New barcode modal #814

Merged
merged 7 commits into from
Apr 24, 2019
Merged

Conversation

madelashmet
Copy link
Contributor

@madelashmet madelashmet commented Apr 23, 2019

Resolves loyno-mathcs#3

Description

Replaced New Barcode Item form in admin view with modal.
Does not complete Bonus.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tests that buttons function, sections can be filled in, and that it saves the information.

Co-Authored-By: Joey Ruzevich [email protected]

@madelashmet
Copy link
Contributor Author

@mdworken Can you take a look at the two Travis CI failures here? They're different problems, and the tests pass fine on my local machine, so I'm not sure what is happening on Travis.

@seanmarcia
Copy link
Member

Looks like travis was having issues with the newest version of node. The master branch has a fix in. I'll merge this in and fix anything that comes up regarding it!

@seanmarcia seanmarcia merged commit 49f9c30 into rubyforgood:master Apr 24, 2019
@armahillo armahillo added ❇️ Github First-timer This Pull Request is a user's first pull-request, EVER Loyola Issues tagged for contributors from Loyola University labels May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❇️ Github First-timer This Pull Request is a user's first pull-request, EVER Loyola Issues tagged for contributors from Loyola University
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5:5:5] Modify Admin::BarcodeItems#new to use Modal instead of standard form
3 participants