Perf: Reduce number of queries and object allocations in request index page #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coalest
changed the title
coalest
force-pushed
the
improve-requests-index-page-perf
branch
from
aa6e65e to
0505ce6
Compare
dorner
approved these changes
Jan 10, 2025
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
I noticed the
/requestspage was slow in development, so I made a few improvements.Type of change
How Has This Been Tested?
Test suite and manually.
Screenshots
Locally, it went from ~2 seconds to ~300 ms for me.
Before:
After:
