Fix the issue where only one error is displayed, even when multiple errors are present. #4911
+59
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozomirin
force-pushed
the
4613-fix-multiple-errors-but-only-show-one-on-distribution
branch
4 times, most recently
from
cc3e80c to
e7d563d
Compare
…rrors are present.
nozomirin
force-pushed
the
4613-fix-multiple-errors-but-only-show-one-on-distribution
branch
from
e7d563d to
6f80c97
Compare
cielf
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Hey @nozomrin -- Thanks for this!
The multiple errors part works well, but you've missed this part of the issue: "The number in brackets after the item (which is the inventory level for that item/storage location) has disappeared -- it should still be there."
Please address.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4613
Description
InventoryActionErrorInventoryErroraggregateInventoryActionErrorsType of change
How Has This Been Tested?
bundle exec rspec spec/events/inventory_aggregate_spec.rbScreenshots