Fix the issue where the exception was not caught when the purchase was distributed. #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Dec 27, 2024
| PurchaseDestroyService.call(purchase) | ||
| begin | ||
| PurchaseDestroyService.call(purchase) | ||
| rescue InventoryError => e |
There was a problem hiding this comment.
Is there a reason you can't catch any StandardError here?
There was a problem hiding this comment.
No. I will change it.
| end | ||
| end | ||
|
|
||
| context "When the purchase has been distributed" do |
There was a problem hiding this comment.
Really all we're testing here is the ability to catch errors. So you can ensure that the delete service throws an error:
allow(PurchaseDestroyService).to receive(:call).and_raise('an error')and you don't need all the setup here.
There was a problem hiding this comment.
Oh, that's really easy. I will change it. Thanks for your review.
nozomirin
force-pushed
the
4886-catch-validation-error-of-purchase-deletion
branch
from
7a88ad3 to
ca9e75d
Compare
|
A definite improvment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4886
Description
I am not sure whether this test is practical. If you have any ideas to improve it, please let me know.
Type of change
How Has This Been Tested?
bundle exec rspec spec/system/purchase_system_spec.rb:296Screenshots