Perf: Minor dashboard index page refactor #4874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coalest
changed the title
coalest
commented
Dec 20, 2024
| @@ -4,9 +4,13 @@ class DashboardController < ApplicationController | |||
|
|
|||
| def index | |||
| @org_stats = OrganizationStats.new(current_organization) | |||
| @total_inventory = current_organization.total_inventory | |||
There was a problem hiding this comment.
This instance variable doesn't appear to be used anywhere.
How removing this line feels:
|
I believe there is also an N+1 regarding partners awaiting review on this page which could be fixed. |
dorner
approved these changes
Dec 20, 2024
|
Thanks for this! |
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
I noticed an N+1 on this page, so I went to fix it.
Then I noticed an unused instance variable and removed one extra query regarding outstanding requests.
Type of change
How Has This Been Tested?
Behavior hasn't changed, so just the automated test suite.