Fix flaky distribution system specs #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were saving a new distribution (which causes a redirect to that distribution's show page) and then immediately clicking on the distributions index page (which redirects as well). This introduced a race condition that was flaky when we tried to click a link that didn't exist on the page.
dorner
approved these changes
Dec 19, 2024
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4381
Description
We were saving a new distribution (which causes a redirect to that distribution's show page) and then immediately clicking on the distributions index page (which redirects as well). This introduced a race condition that was flaky when we tried to click a link that didn't exist on the page we were on.
Type of change
How Has This Been Tested?
I was actually able to reproduce this failure locally, so it was a little easier to test. I ran the three specs that use the faulty
beforeblock multiple times before and after this change. (Using a simple bash script to run the test multiple times:for i in {1..20}; do ber spec/system/distribution_system_spec.rb:559; done;)Before the change:
5 failing specs out of 60.
After the change:
0 failing specs out of 60.