Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing partner dropdown options on distribution update fail #4868

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Dec 18, 2024

Doesn't resolve any issue.

Description

This bug was discovered while I was working on #4849.

Steps to reproduce:

  1. Log in as an org_admin.
  2. Find a distribution and click edit.
  3. Change something on the page to create a validation error. (For example, set the issue date year to be 1000.)
  4. Click save/update.
  5. The update should fail, and now the dropdown for partners will be messed up. Instead of valid partner names, you see something like the screenshot below.

Expected behavior: You should see the same partner names as before the failed update.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Locally and I added a new request spec.

Screenshots

image

@coalest coalest force-pushed the fix-missing-partners-on-distribution-update-failure-bug branch from 29f9121 to 4ebbf25 Compare December 18, 2024 18:49
@coalest coalest changed the title Fix missing partner dropdown options of distribution update fail Fix missing partner dropdown options on distribution update fail Dec 18, 2024
@cielf
Copy link
Collaborator

cielf commented Dec 18, 2024

Works as advertised

@cielf cielf requested a review from dorner December 18, 2024 22:35
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dorner dorner merged commit 3908561 into rubyforgood:main Dec 19, 2024
11 checks passed
Copy link
Contributor

@coalest: Your PR Fix missing partner dropdown options on distribution update fail is part of today's Human Essentials production release: 2024.12.22.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants