Refactor out for_families attribute from FamilyRequestCreateService #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, I've added whether partner requests can be deleted to our planning meeting list (but it's not near the top) |
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't resolve any issue.
Description
This
for_familiesattribute is a funny one. I removed it fromRequestCreateServicein PR #4827, because it was being passed in but then not used.Let's go ahead and remove it from
FamilyCreateServiceas I think it isn't necessary there either.It also appears to be a column on the
partner_requeststable which as far as I can tell is currently not being used. Not sure if it was ever used.A side topic is what to do about the
partner_requeststable. Can we drop it or does it have records in production?Type of change
How Has This Been Tested?
Fixed related tests that references
for_families.